Verifier "Could not verify all goals" improperly truncates the printed goal
OpenPublic

Description

The last character in a goal is missing from the error message. I think that this fixes the bug:

  • kythe/cxx/verifier/verifier.cc

+++ kythe/cxx/verifier/verifier.cc
@@ -741,7 +741,7 @@ void Verifier::DumpErrorGoal(size_t group, size_t index) {

FILE *f = fopen(goal_end.filename->c_str(), "r");
printed_goal =
    PrintFileSection(f, goal_begin.line - 1, goal_begin.column - 1,
  • goal_end.line - 1, goal_end.column - 1, &printer);

+ goal_end.line - 1, goal_end.column, &printer);

  fclose(f);
}
pludemann created this task.Via WebNov 25 2016, 12:05 PM
pludemann added a subscriber: pludemann.
salguarnieri triaged this task as "Low" priority.Via WebDec 8 2016, 5:48 PM
salguarnieri added a subscriber: salguarnieri.

Add Comment